rt: Remove dead code from schedule_task() #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks good to me. Next time I write |
brson
added a commit
that referenced
this pull request
Jan 1, 2013
rt: Remove dead code from schedule_task()
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2020
…1995 Improvements for `type_repetition_in_bounds` lint Some improvements for `type_repetition_in_bounds`: - add a configurable threshold to trigger the lint (rust-lang#4380). The lint won't trigger anymore if there are more bounds (strictly) than `conf.max_trait_bounds` on this type. - take generic args into account over bounded type (rust-lang#4323) - don't lint for predicates generated in macros (rust-lang#4326) Fixes rust-lang#4380, Fixes rust-lang#4323, Fixes rust-lang#4326, Closes rust-lang#3764 changelog: Fix multiple FPs in `type_repetition_in_bounds` and add a configuration option Note: the rust-lang#3764 has already been fixed but not closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schedule_task()had a useless loop left over from when therunning_taskslist was searched linearly for a runnable task.schedule_task()assertedthisis not null. This is not a very useful assertion, especially since the function already dereferencedthis->lock. :)number_of_live_tasks()accessedrunning_tasksandblocked_taskslists without a lock.